Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgis search fix #1475

Merged
merged 4 commits into from Jul 21, 2023
Merged

Postgis search fix #1475

merged 4 commits into from Jul 21, 2023

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

Queries against numeric search fields in the postgis driver were broken. The SQL queries were not being generated correctly AND the actual search index was not being populated correctly.

Proposed changes

  • Fix SQL query generation for numeric searches

  • Fix numeric search index population

  • Add tests to ensure that similar issues are identified earlier in future.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (c7dae08) 85.10% compared to head (144252f) 85.18%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1475      +/-   ##
===============================================
+ Coverage        85.10%   85.18%   +0.08%     
===============================================
  Files              130      130              
  Lines            14348    14352       +4     
===============================================
+ Hits             12211    12226      +15     
+ Misses            2137     2126      -11     
Impacted Files Coverage Δ
datacube/drivers/postgis/_api.py 87.34% <100.00%> (+0.07%) ⬆️
datacube/drivers/postgis/_fields.py 91.04% <100.00%> (+0.37%) ⬆️
datacube/index/postgis/_datasets.py 75.12% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@omad omad self-assigned this Jul 21, 2023
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@omad omad merged commit c97bf11 into develop-1.9 Jul 21, 2023
22 checks passed
@omad omad deleted the postgis-search-fix branch July 21, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants