New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings #1476
Fix deprecation warnings #1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Tested to confirm it fixes the warnings I had been getting.
…hema does not exist.
…s" clauses properly in 1.4.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1476 +/- ##
========================================
Coverage 91.78% 91.78%
========================================
Files 132 132
Lines 14526 14530 +4
========================================
+ Hits 13333 13337 +4
Misses 1193 1193
☔ View full report in Codecov by Sentry. |
Reason for this pull request
Some upstream libraries were raising deprecation warnings from core, as reported in #1474
Proposed changes
Update SQLAlchemy calls to suppress remaining deprecation warnings.
Pin
jsonschema<4.18
to suppress deprecation warnings from old (RefResolver) API. (Move to the new API will be done in a separate PR, to be merged once jsonschema 4.18+ has stabilised.)Closes Deprecation Warnings from
jsonschema
and SQLAlchemy #1474Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes📚 Documentation preview 📚: https://datacube-core--1476.org.readthedocs.build/en/1476/