Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #1476

Merged
merged 6 commits into from Jul 24, 2023
Merged

Fix deprecation warnings #1476

merged 6 commits into from Jul 24, 2023

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jul 24, 2023

Reason for this pull request

Some upstream libraries were raising deprecation warnings from core, as reported in #1474

Proposed changes

  • Update SQLAlchemy calls to suppress remaining deprecation warnings.

  • Pin jsonschema<4.18 to suppress deprecation warnings from old (RefResolver) API. (Move to the new API will be done in a separate PR, to be merged once jsonschema 4.18+ has stabilised.)

  • Closes Deprecation Warnings from jsonschema and SQLAlchemy  #1474

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1476.org.readthedocs.build/en/1476/

@SpacemanPaul SpacemanPaul requested a review from omad July 24, 2023 01:00
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Tested to confirm it fixes the warnings I had been getting.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 90.62% and no project coverage change.

Comparison is base (95b6f43) 91.78% compared to head (ac52a4a) 91.78%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1476   +/-   ##
========================================
  Coverage    91.78%   91.78%           
========================================
  Files          132      132           
  Lines        14526    14530    +4     
========================================
+ Hits         13333    13337    +4     
  Misses        1193     1193           
Impacted Files Coverage Δ
datacube/drivers/postgres/_core.py 96.29% <87.50%> (+0.03%) ⬆️
datacube/drivers/postgis/_api.py 87.31% <100.00%> (+0.03%) ⬆️
datacube/drivers/postgis/_core.py 95.04% <100.00%> (+0.10%) ⬆️
datacube/index/postgis/_datasets.py 74.81% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SpacemanPaul SpacemanPaul merged commit 53eb54d into develop Jul 24, 2023
25 checks passed
@SpacemanPaul SpacemanPaul deleted the fix_deprecation_warnings branch July 24, 2023 02:23
@SpacemanPaul SpacemanPaul mentioned this pull request Jul 24, 2023
2 tasks
SpacemanPaul added a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warnings from jsonschema and SQLAlchemy
2 participants