New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial index api #1481
Merged
Merged
Spatial index api #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1481 +/- ##
===============================================
+ Coverage 85.18% 85.23% +0.05%
===============================================
Files 130 131 +1
Lines 14358 14532 +174
===============================================
+ Hits 12231 12387 +156
- Misses 2127 2145 +18
☔ View full report in Codecov by Sentry. |
Ariana-B
reviewed
Aug 18, 2023
Ariana-B
reviewed
Aug 18, 2023
Ariana-B
reviewed
Aug 21, 2023
Ariana-B
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Formalise the Spatial index API and expose in CLI.
Proposed changes
API method for dropping/removing an existing spatial index.
Formalise spatial index API at the index/abstract.py level (and add driver "supports" flag so index drivers can advertise whether or not they support the API.)
CLI entry points for creating, updating, dropping and listing spatial indexes.
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes