Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial index api #1481

Merged
merged 15 commits into from Aug 21, 2023
Merged

Spatial index api #1481

merged 15 commits into from Aug 21, 2023

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Aug 4, 2023

Reason for this pull request

Formalise the Spatial index API and expose in CLI.

Proposed changes

  • API method for dropping/removing an existing spatial index.

  • Formalise spatial index API at the index/abstract.py level (and add driver "supports" flag so index drivers can advertise whether or not they support the API.)

  • CLI entry points for creating, updating, dropping and listing spatial indexes.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 89.60% and project coverage change: +0.05% 🎉

Comparison is base (9ef6456) 85.18% compared to head (2f091fd) 85.23%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1481      +/-   ##
===============================================
+ Coverage        85.18%   85.23%   +0.05%     
===============================================
  Files              130      131       +1     
  Lines            14358    14532     +174     
===============================================
+ Hits             12231    12387     +156     
- Misses            2127     2145      +18     
Files Changed Coverage Δ
datacube/index/postgres/index.py 100.00% <ø> (+1.05%) ⬆️
datacube/index/abstract.py 89.26% <71.42%> (+0.09%) ⬆️
datacube/scripts/spindex.py 88.96% <88.96%> (ø)
datacube/drivers/postgis/_connections.py 83.57% <93.33%> (+0.11%) ⬆️
datacube/drivers/postgis/_api.py 87.34% <100.00%> (ø)
datacube/drivers/postgis/_spatial.py 94.02% <100.00%> (-0.09%) ⬇️
datacube/index/postgis/_datasets.py 75.12% <100.00%> (ø)
datacube/index/postgis/index.py 100.00% <100.00%> (ø)
datacube/scripts/cli_app.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review August 8, 2023 00:29
datacube/scripts/spindex.py Outdated Show resolved Hide resolved
datacube/scripts/spindex.py Outdated Show resolved Hide resolved
datacube/drivers/postgis/_connections.py Show resolved Hide resolved
datacube/drivers/postgis/_spatial.py Outdated Show resolved Hide resolved
datacube/drivers/postgis/_spatial.py Outdated Show resolved Hide resolved
datacube/drivers/postgis/_spatial.py Outdated Show resolved Hide resolved
datacube/index/abstract.py Show resolved Hide resolved
datacube/scripts/spindex.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@SpacemanPaul SpacemanPaul merged commit ab2a044 into develop-1.9 Aug 21, 2023
22 checks passed
@SpacemanPaul SpacemanPaul deleted the spatial_index_api branch August 21, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants