Fix push to pypi

[Ariana-B]

Reason for this pull request

PyPi action is still broken.

Proposed changes

• Put back step to push to test pypi (secrets.TestPyPiToken is missing or invalid, needs to be updated)

• Fix bash syntax for setting push_pypi

• Closes #xxxx

• Tests added / passed

• Fully documented, including docs/about/whats_new.rst for all changes

---

📚 Documentation preview 📚: https://datacube-core--1496.org.readthedocs.build/en/1496/

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (9924bac) 91.79% compared to head (2f414cd) 91.79%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1496   +/-   ##
========================================
  Coverage    91.79%   91.79%           
========================================
  Files          132      132           
  Lines        14537    14537           
========================================
  Hits         13344    13344           
  Misses        1193     1193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[omad]

Thanks Ariana, this will probably make it work again.

I think we need to totally redo this GHA workflow though, it's enough to give me nightmares with:

• the way it's running everything inside docker
• conditionally rebuilding the entire docker image
• has testing + building packages + building docker images + publishing docker images + publishing to pypi all wrapped up in the same Job
• behaviour is completely dependent on https://github.com/opendatacube/datacube-core/blob/develop/docker/assets/with_bootstrap
• confusing logic spread around everywhere as to which steps are run and when.

But, lets fix that another day... :)

[omad]

These two lines have no effect, they're setting environment variables that are never exported or used.

[omad]

We're not using these two settings separately, either we push to both test and real pypi, or we do neither.

[Ariana-B]

Yeah, I thought I'd leave them both in just in case we want to introduce an additional trigger condition for test pypi. It can be refined up with the next update to the workflow I suppose