New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP10 config #1505
EP10 config #1505
Conversation
…tion names; pgsql url reconstruction method
…tion names; pgsql url reconstruction method
# Conflicts: # setup.py
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1505 +/- ##
===============================================
+ Coverage 85.19% 85.37% +0.18%
===============================================
Files 131 137 +6
Lines 14551 14784 +233
===============================================
+ Hits 12396 12622 +226
- Misses 2155 2162 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a decent config update should merge and let errors in deployments pop out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks generally fine to me, thank you Paul! Sorry it's taken me so long to respond.
The documentation is very comprehensive. I think there's room for improvement it making it easy to understand, but that's not at all a blocker for merging.
I made a bunch of documentation fixes already, but there's a few more sphinx niceties I'll add, remove the need for the numbered headings.
Overall, my remaining concern is that this is still more complicated than we need, in terms of how configuration is resolved between searching for files in multiple places, as well as environment variables. But it is at least a bit simpler to think about than before, and the implementation looks a lot better.
Reason for this pull request
Ground-up backwards-incompatible rewrite of config engine, as per ODC-EP10 Replace Configuration Layer
Proposed changes
New Config engine implemented and tested, as per EP.
Remove old config engine.
API documentation (in docstrings)
User documentation (for readthedocs)
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes