Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridspec in virtual product tests #1512

Merged
merged 5 commits into from Nov 13, 2023
Merged

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

Virtual Product tests were throwing a deprecation warning because they use the old datacube GridSpec. Also that deprecation warning had a spelling mistake,

Proposed changes

  • Correct the spelling of the GridSpec deprecation warning.

  • Get virtual products tests using the odc-geo GridSpec class.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e74a27b) 85.22% compared to head (95a08a4) 85.19%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1512      +/-   ##
===============================================
- Coverage        85.22%   85.19%   -0.04%     
===============================================
  Files              131      131              
  Lines            14551    14551              
===============================================
- Hits             12401    12396       -5     
- Misses            2150     2155       +5     
Files Coverage Δ
datacube/model/__init__.py 95.14% <ø> (-0.38%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul merged commit 41c33cf into develop-1.9 Nov 13, 2023
28 checks passed
@SpacemanPaul SpacemanPaul deleted the gridspec_in_virtprod_tests branch November 13, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants