Make solar_date() timezone aware. #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1521 +/- ##
===========================================
+ Coverage 91.75% 91.79% +0.03%
===========================================
Files 132 132
Lines 14552 14617 +65
===========================================
+ Hits 13352 13417 +65
Misses 1200 1200 ☔ View full report in Codecov by Sentry. |
Ariana-B
approved these changes
Dec 12, 2023
SpacemanPaul
added a commit
that referenced
this pull request
Dec 19, 2023
2 tasks
SpacemanPaul
added a commit
that referenced
this pull request
Dec 20, 2023
* Update whats_new.rst for 1.8.17 release. (#1510) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/adrienverge/yamllint.git: v1.32.0 → v1.33.0](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.33.0) * Bump conda-incubator/setup-miniconda from 2 to 3 Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 2 to 3. - [Release notes](https://github.com/conda-incubator/setup-miniconda/releases) - [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md) - [Commits](conda-incubator/setup-miniconda@v2...v3) --- updated-dependencies: - dependency-name: conda-incubator/setup-miniconda dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Dataset CLI tool to find duplicates (#1517) * add dataset cli tool to find duplicates * convert timestamps to UTC * update whats_new * update memory driver search duplicates implementation --------- Co-authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au> * Make solar_date() timezone aware. (#1521) * Warn if non-eo3 dataset has eo3 metadata type (#1523) * warn if non-eo3 dataset has eo3 metadata type * fix str contains * add test --------- Co-authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au> * Fix merge oops * Resolve some merge issues arising fromm differences between SQLAlchemy 1.4 and 2.0. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariana-B <40238244+ariana-b@users.noreply.github.com> Co-authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
The
datacube.api.query.solar_date()function takes a dataset object and calculates it's local solar date, based on center time and central longitude. However, it assumes that the dataset center_time is in UTC timezone. If the the center_time is in some other timezone, an incorrect date may be returned.See also: opendatacube/datacube-ows#979
Proposed changes
Call
.astimezone(utc)on the center time before doing solar date calculations.Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1521.org.readthedocs.build/en/1521/