Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pandas version in docker image #1527

Merged
merged 5 commits into from Jan 4, 2024
Merged

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Jan 3, 2024

Reason for this pull request

Pandas 2.0 defaults to datetime.timezone instead of pytz for tzinfo. This causes the Query.__init__ docstring test to fail when run in the conda environment but pass when run with docker, which has pandas 1.5.

Proposed changes

  • Update docstring test to expect datetime.timezone.utc instead of <UTC> in the timestamp
  • Update docker image constraints to match pandas version in conda env

(Relevant changes are in docker/constraints.in, docker/constraints.txt, and datacube/api/query.py (plus of course docs/about/whats_new.rst). The other file changes are due to the copyright headers being automatically updated to the current year.)


📚 Documentation preview 📚: https://datacube-core--1527.org.readthedocs.build/en/1527/

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9fb8c8c) 91.75% compared to head (01f03c2) 91.79%.
Report is 5 commits behind head on develop.

❗ Current head 01f03c2 differs from pull request most recent head b48304f. Consider uploading reports for the commit b48304f to get more accurate results

Files Patch % Lines
datacube/index/memory/_datasets.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1527      +/-   ##
===========================================
+ Coverage    91.75%   91.79%   +0.04%     
===========================================
  Files          132      132              
  Lines        14552    14624      +72     
===========================================
+ Hits         13352    13424      +72     
  Misses        1200     1200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think it would be easier to pin pandas directly in constraints.in

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,.

@Ariana-B Ariana-B merged commit b9ba239 into develop Jan 4, 2024
30 checks passed
@Ariana-B Ariana-B deleted the update_docker_pandas branch January 4, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Query doctest fails due to different timezone representation
2 participants