New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pandas version in docker image #1527
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1527 +/- ##
===========================================
+ Coverage 91.75% 91.79% +0.04%
===========================================
Files 132 132
Lines 14552 14624 +72
===========================================
+ Hits 13352 13424 +72
Misses 1200 1200 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I think it would be easier to pin pandas
directly in constraints.in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,.
Reason for this pull request
Pandas 2.0 defaults to
datetime.timezone
instead ofpytz
fortzinfo
. This causes theQuery.__init__
docstring test to fail when run in the conda environment but pass when run with docker, which has pandas 1.5.Proposed changes
datetime.timezone.utc
instead of<UTC>
in the timestamp(Relevant changes are in
docker/constraints.in
,docker/constraints.txt
, anddatacube/api/query.py
(plus of coursedocs/about/whats_new.rst
). The other file changes are due to the copyright headers being automatically updated to the current year.)docs/about/whats_new.rst
for all changes📚 Documentation preview 📚: https://datacube-core--1527.org.readthedocs.build/en/1527/