Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ep13 Dataset API - Phase 1 #1538

Merged
merged 10 commits into from Jan 29, 2024
Merged

Ep13 Dataset API - Phase 1 #1538

merged 10 commits into from Jan 29, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jan 24, 2024

Reason for this pull request

First batch of dataset resource API changes from EP13 - Index Driver API cleanup

Proposed changes

  • Add new get_unsafe() method for consistency with other resources. Implement get with get_unsafe

  • Add new arguments to get and get_unsafe for EP8 lineage handling - implement in postgis driver

  • Deprecate get_derived() method

  • Implement get_product_time_bounds() with new temporal_extent method. Not fully implemented in postgres driver for "boring technical reasons", as per EP13.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb42559) 85.30% compared to head (f41718f) 85.41%.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1538      +/-   ##
===============================================
+ Coverage        85.30%   85.41%   +0.11%     
===============================================
  Files              140      140              
  Lines            14994    15040      +46     
===============================================
+ Hits             12790    12846      +56     
+ Misses            2204     2194      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review January 24, 2024 23:56
@SpacemanPaul SpacemanPaul merged commit ad78e75 into develop-1.9 Jan 29, 2024
28 checks passed
@SpacemanPaul SpacemanPaul deleted the ep13_ds_api branch January 29, 2024 02:12
@SpacemanPaul SpacemanPaul mentioned this pull request Jan 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants