Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search api 1 cleanup #1541

Merged
merged 7 commits into from Feb 5, 2024
Merged

Search api 1 cleanup #1541

merged 7 commits into from Feb 5, 2024

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

Take advantage of Python 3.10 type hint enhancements, and fix incorrect typehints.

  • Tests added / passed
  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9585230) 85.43% compared to head (c44991b) 85.43%.

❗ Current head c44991b differs from pull request most recent head 7a8a29a. Consider uploading reports for the commit 7a8a29a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1541   +/-   ##
============================================
  Coverage        85.43%   85.43%           
============================================
  Files              140      140           
  Lines            15044    15047    +3     
============================================
+ Hits             12853    12856    +3     
  Misses            2191     2191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review February 5, 2024 21:33
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@omad omad merged commit b0946a3 into develop-1.9 Feb 5, 2024
24 checks passed
@omad omad deleted the search_api_1_cleanup branch February 5, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants