Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to ignore lineage when indexing, #398 #473

Merged
merged 2 commits into from Jun 4, 2018
Merged

Conversation

Kirill888
Copy link
Member

Reason for this pull request

During new product development it is often necessary to create temporary databases to index new product data for reviewing purposes. This can often take long time due to lineage data being added to the fresh db, even though it is not relevant in this context (the DB is transient and will be deleted anyway, and the tests do not care about lineage data).

Proposed changes

  • Add --ignore-lineage and --confirm-ignore-lineage options

The first one only works during interactive runs and asks user to confirm the intent, second one can be used in scripts.

@Kirill888 Kirill888 requested a review from omad June 4, 2018 05:22
@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage decreased (-0.06%) to 82.701% when pulling 7c39307 on ignore-lineage into 3b23771 on develop.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omad omad merged commit ab0d0d8 into develop Jun 4, 2018
@omad omad deleted the ignore-lineage branch June 4, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants