Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for google storage buckets #653

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

tom-butler
Copy link
Contributor

Reason for this pull request

When pointing datacube at a google storage url (gs://) it threw Unexpected server error: Expecting URL with scheme here

Proposed changes

  • register the gs:// scheme

  • fix spacing issue in test_index_duplicate_dataset

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Fix failing integration test
Copy link
Member

@Kirill888 Kirill888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #653 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
+ Coverage    87.78%   87.78%   +<.01%     
===========================================
  Files          101      101              
  Lines         8774     8775       +1     
===========================================
+ Hits          7702     7703       +1     
  Misses        1072     1072
Impacted Files Coverage Δ
datacube/utils/uris.py 99.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1161d...e7b1847. Read the comment docs.

@mergify mergify bot merged commit d6a6c09 into develop Feb 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the register-gs-scheme branch February 8, 2019 04:59
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 87.738% when pulling e7b1847 on register-gs-scheme into ae1161d on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants