Replace CLI Search Expressions #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyh
previously approved these changes
Dec 19, 2019
datacube/scripts/dataset.py
Outdated
| Delete Dataset(s) from the database | ||
|
|
||
| Easy if they have nothing derived from them. | ||
| """ |
There was a problem hiding this comment.
Accidental inclusion? (empty stub methods)
There was a problem hiding this comment.
Whoops, thanks, yep. I'll clean it up. :)
Codecov Report
@@ Coverage Diff @@
## develop #840 +/- ##
===========================================
+ Coverage 88.63% 88.66% +0.03%
===========================================
Files 112 112
Lines 10381 10270 -111
===========================================
- Hits 9201 9106 -95
+ Misses 1180 1164 -16
Continue to review full report at Codecov.
|
Kirill888
reviewed
Dec 19, 2019
datacube/scripts/product.py
Outdated
|
|
||
| If the product does have Datasets, suggest how to delete the datasets. | ||
|
|
||
| """ |
There was a problem hiding this comment.
more accidental stub commits?
In some places the literal '2019' was interpreted as a datetime(2019, 1, 1) and in others as the int 2019.dra/use-larkparser I think it should be made consistent, rather than trying to maintain backwards compatibility.
Flip pytest asserts to be the correct way, like assert f() == 4 See https://docs.pytest.org/en/latest/assert.html This makes the error messages much less concerning wrt expected/actual labels
improvements to parse_expressions using lark
Remove PyPEG2 dependency
Return an empty dict
omad
force-pushed
the
dra/use-larkparser
branch
from
434113b
to
8d7c79e
Compare
Kirill888
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
I would like to replace the search expressions used in several datacube command line tools with a more manageable and understandable alternative.
The existing search expressions have confused a few new users, they have grown since initially implemented, but haven't had old options removed. The implementation is also based on PyPEG2, a no longer supported or updated parsing library. Due to it's rarity, this dependency has created several dependency graph issues with datacube in conda-forge.
Proposed changes
in range()syntax, which also required shell escaping, and wasn't clear whether it supported single or multiple dates or only numbers.Available Search Expressions
Thanks @uchchwhash for a lot of the hard work!
docs/about/whats_new.rstfor all changes