Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csiro/mk uri #960

Merged
merged 9 commits into from Jun 2, 2020
Merged

Csiro/mk uri #960

merged 9 commits into from Jun 2, 2020

Conversation

petewa
Copy link
Contributor

@petewa petewa commented Jun 2, 2020

Moved mk_uri function from ingest.py to Writer Driver

Before mk_uri was set by the ingest specifically for the NetCDF driver
Now mk_uri can be set by the Writer Driver in a form that it understands.

This also avoids the need for multiple writer endpoints in setup.py, should the driver supports multiple protocols/schemes.

Proposed changes

  • Move mk_uri from ingest.py into Writer Driver

  • Change write_dataset_to_storage parameter from filename to file_uri

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

@petewa petewa requested a review from Kirill888 June 2, 2020 01:45
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #960 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #960      +/-   ##
===========================================
+ Coverage    92.94%   92.95%   +0.01%     
===========================================
  Files           97       97              
  Lines         9648     9649       +1     
===========================================
+ Hits          8967     8969       +2     
+ Misses         681      680       -1     
Impacted Files Coverage Δ
datacube/drivers/netcdf/driver.py 100.00% <100.00%> (ø)
datacube/scripts/ingest.py 83.71% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1884d3...ce3cf83. Read the comment docs.

docs/about/whats_new.rst Outdated Show resolved Hide resolved
Copy link
Member

@Kirill888 Kirill888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@petewa
Copy link
Contributor Author

petewa commented Jun 2, 2020

Thank you Kirill for going through the PR.

@petewa petewa merged commit c2c25d3 into develop Jun 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the csiro/mk_uri branch June 2, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants