New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csiro/mk uri #960
Csiro/mk uri #960
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #960 +/- ##
===========================================
+ Coverage 92.94% 92.95% +0.01%
===========================================
Files 97 97
Lines 9648 9649 +1
===========================================
+ Hits 8967 8969 +2
+ Misses 681 680 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Thank you Kirill for going through the PR. |
Moved
mk_uri
function fromingest.py
to Writer DriverBefore
mk_uri
was set by the ingest specifically for the NetCDF driverNow
mk_uri
can be set by the Writer Driver in a form that it understands.This also avoids the need for multiple writer endpoints in
setup.py
, should the driver supports multiple protocols/schemes.Proposed changes
Move
mk_uri
from ingest.py into Writer DriverChange
write_dataset_to_storage
parameter fromfilename
tofile_uri
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes