Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.8.2 release #989

Merged
merged 7 commits into from Jul 10, 2020
Merged

Prepare for 1.8.2 release #989

merged 7 commits into from Jul 10, 2020

Conversation

Kirill888
Copy link
Member

@Kirill888 Kirill888 commented Jul 10, 2020

Reason for this pull request

1.8.1 had a regression in .geobox. It only applies to re-injected CRS data, but example notebooks do that, so this has been fixed and we need to make a new release soon. Getting some easy fixes in before that.

Proposed changes

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #989 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #989      +/-   ##
===========================================
+ Coverage    92.98%   93.00%   +0.02%     
===========================================
  Files           97       97              
  Lines         9703     9733      +30     
===========================================
+ Hits          9022     9052      +30     
  Misses         681      681              
Impacted Files Coverage Δ
datacube/utils/rio/_rio.py 100.00% <ø> (ø)
datacube/scripts/dataset.py 88.97% <100.00%> (+0.78%) ⬆️
datacube/utils/aws/__init__.py 100.00% <100.00%> (ø)
datacube/utils/documents.py 97.80% <100.00%> (+0.05%) ⬆️
datacube/utils/py.py 100.00% <100.00%> (ø)
datacube/utils/xarray_geoextensions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcab0e0...1963ae4. Read the comment docs.

@Kirill888 Kirill888 marked this pull request as ready for review July 10, 2020 06:46
@Kirill888 Kirill888 requested review from omad and jeremyh July 10, 2020 06:46
@@ -35,6 +35,31 @@ def maybe_remap(s):
return maybe_remap


def _resolve_uri(uri, doc):
loc = doc.location
Copy link
Contributor

@jeremyh jeremyh Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pop the location(s) out of the document, similar to what's done with the lineage, since they're already stored separately in the DB (and are modified separately with other apis -- leaving possibly-inconsistent duplicate copies of the locations)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will then force it to be a string and not a list, because popping list will loose data as the rest of the code assume single uri when you first inject the dataset into DB

@Kirill888 Kirill888 merged commit 6d41f4f into develop Jul 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the prep-1.8.2 branch July 10, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants