New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 1.8.2 release #989
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #989 +/- ##
===========================================
+ Coverage 92.98% 93.00% +0.02%
===========================================
Files 97 97
Lines 9703 9733 +30
===========================================
+ Hits 9022 9052 +30
Misses 681 681
Continue to review full report at Codecov.
|
@@ -35,6 +35,31 @@ def maybe_remap(s): | |||
return maybe_remap | |||
|
|||
|
|||
def _resolve_uri(uri, doc): | |||
loc = doc.location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should pop the location(s) out of the document, similar to what's done with the lineage, since they're already stored separately in the DB (and are modified separately with other apis -- leaving possibly-inconsistent duplicate copies of the locations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will then force it to be a string and not a list, because popping list will loose data as the rest of the code assume single uri when you first inject the dataset into DB
Reason for this pull request
1.8.1
had a regression in.geobox
. It only applies to re-injected CRS data, but example notebooks do that, so this has been fixed and we need to make a new release soon. Getting some easy fixes in before that.Proposed changes
Extend allowed dtype enum with
complex64
,complex128
Be robust when traversing lineage
Understand
location
field in dataset documentDocument
configure_s3_access
in the api docsSome other documentation tweaks
Closes 'NoneType' object has no attribute 'items' when indexing dataset. #988
Closes Allow specifying dataset location from within the yaml document #990
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes