Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1012

Merged
merged 31 commits into from
Apr 30, 2024
Merged

Cleanup #1012

merged 31 commits into from
Apr 30, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Apr 24, 2024

  • Added, fixed and updated type hints throughout.
  • Split data.py into 3 modules. The new modules are loading.py and feature_info.py.
  • Split ogc_utils.py into 3 modules. The new modules are http_utils.py and time_utils.py
  • Redundant pool of connection pools greatly simplified
  • Fix documentation typos noted from 1.9 postgres compatibility #1009
  • Several weird corner case bugs fixed or at least commented.
  • Added mypy github check
  • removed isort github check
  • applied Robbi's Fix data links for products indexed with STAC metadata #1011 fix
  • Updated license headers

📚 Documentation preview 📚: https://datacube-ows--1012.org.readthedocs.build/en/1012/

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 91.56627% with 126 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop-1.9@22c4a78). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop-1.9    #1012   +/-   ##
==============================================
  Coverage               ?   93.77%           
==============================================
  Files                  ?       47           
  Lines                  ?     6631           
  Branches               ?        0           
==============================================
  Hits                   ?     6218           
  Misses                 ?      413           
  Partials               ?        0           
Files Coverage Δ
datacube_ows/__init__.py 100.00% <ø> (ø)
datacube_ows/band_utils.py 99.32% <ø> (ø)
datacube_ows/cfg_parser_impl.py 98.68% <100.00%> (ø)
datacube_ows/config_toolkit.py 100.00% <100.00%> (ø)
datacube_ows/cube_pool.py 100.00% <100.00%> (ø)
datacube_ows/gunicorn_config.py 0.00% <ø> (ø)
datacube_ows/legend_generator.py 100.00% <100.00%> (ø)
datacube_ows/legend_utils.py 94.11% <ø> (ø)
datacube_ows/ogc.py 85.18% <100.00%> (ø)
datacube_ows/ogc_exceptions.py 98.50% <100.00%> (ø)
... and 37 more

@SpacemanPaul SpacemanPaul marked this pull request as ready for review April 24, 2024 10:44
@SpacemanPaul SpacemanPaul requested a review from omad April 30, 2024 00:28
isort --check --diff .
update-conda: true
python-version: ${{ matrix.python-version }}
conda-channels: anaconda, conda-forge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so weird, the documentation for the s-weigand/setup-conda action does define that the Last channel gets the highest priority. So, this is correct and what we want, it just looks really weird.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too much in a PR, but, the automated checks pass, so, Approve.

@omad omad merged commit a846880 into develop-1.9 Apr 30, 2024
7 checks passed
@omad omad deleted the cleanup branch April 30, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants