Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle credentials rotation #114

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Handle credentials rotation #114

merged 2 commits into from
Jan 17, 2024

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Jan 16, 2024

Changes:

  • removed the static credentials, let boto3.client handle the credentials rotation
  • changed how s3_client (ref:Gather s3 operations into class odc-tools#597) is managed on dask cluster, one for scheduler and one per work (among all threads rather than each per thread)

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but obviously can't be merged until the changes in odc-cloud are released.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ec3cdd3) 76.38% compared to head (6e23284) 76.59%.
Report is 2 commits behind head on develop.

Files Patch % Lines
odc/stats/io.py 54.54% 5 Missing ⚠️
odc/stats/proc.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
+ Coverage    76.38%   76.59%   +0.21%     
===========================================
  Files           34       34              
  Lines         3210     3205       -5     
===========================================
+ Hits          2452     2455       +3     
+ Misses         758      750       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmaai emmaai merged commit ad12ac3 into develop Jan 17, 2024
5 checks passed
@emmaai emmaai deleted the fix_credentials branch January 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants