Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deafrica settings optional #16

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Make deafrica settings optional #16

merged 4 commits into from
Dec 22, 2021

Conversation

alexgleith
Copy link
Contributor

  • Should make all the DE Africa configuration optional for DEA.

@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #16 (48d3a59) into develop (58abb4a) will increase coverage by 0.01%.
The diff coverage is 83.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
+ Coverage    61.83%   61.85%   +0.01%     
===========================================
  Files           19       19              
  Lines         1837     1848      +11     
===========================================
+ Hits          1136     1143       +7     
- Misses         701      705       +4
Impacted Files Coverage Δ
odc/stats/plugins/fc_percentiles.py 88.75% <83.33%> (-4.01%) ⬇️
odc/stats/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58abb4a...48d3a59. Read the comment docs.

emmaai
emmaai approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alexgleith alexgleith merged commit 9f0844d into develop Dec 22, 2021
@alexgleith alexgleith deleted the make-deafrica-settings-optional branch December 22, 2021 02:29
emmaai pushed a commit that referenced this pull request Sep 30, 2022
@alexgleith
Merge pull request #16 from opendatacube/kk
c210b00 
Rewrite stats docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmaai emmaai emmaai approved these changes

@cbur24 cbur24 Awaiting requested review from cbur24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexgleith @emmaai