Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in CLI option to handle collection_category flag #22

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

alexgleith
Copy link
Contributor

Simpler than I thought it would be.

Turns out we really shouldn't have implemented the dataset_filter option and just used this existing predicate logic...

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #22 (229a207) into develop (c30a71e) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
- Coverage    62.01%   61.88%   -0.13%     
===========================================
  Files           20       20              
  Lines         1940     1944       +4     
===========================================
  Hits          1203     1203              
- Misses         737      741       +4     
Impacted Files Coverage Δ
odc/stats/tasks.py 39.55% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30a71e...229a207. Read the comment docs.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current predicate implementation seems very odd to me.

Why are lsn_sr products handled separately, and why are they hard-coded? Why does it default to True for non lsn_sr products?

odc/stats/_cli_save_tasks.py Show resolved Hide resolved
@alexgleith alexgleith force-pushed the add-collection-category-predicate branch from 1fc665c to 229a207 Compare February 23, 2022 02:12
odc/stats/_cli_save_tasks.py Show resolved Hide resolved
@alexgleith alexgleith merged commit a0c9793 into develop Feb 23, 2022
@alexgleith alexgleith deleted the add-collection-category-predicate branch February 23, 2022 05:29
emmaai pushed a commit that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants