Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change failure exit code #27

Merged
merged 2 commits into from
Mar 22, 2022
Merged

change failure exit code #27

merged 2 commits into from
Mar 22, 2022

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Mar 22, 2022

Require a non 0 exit code to mark the failure and trigger retry. It is not a good practice to exit everything with 0.
Scenario on k8s:

  • liveness probe run every 5s
  • within 5s interval stats failed and exit 0
  • nobody knows which ones failed which one succeeded

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #27 (1ed13e8) into develop (5346762) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #27   +/-   ##
========================================
  Coverage    61.82%   61.82%           
========================================
  Files           20       20           
  Lines         1949     1949           
========================================
  Hits          1205     1205           
  Misses         744      744           
Impacted Files Coverage Δ
odc/stats/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5346762...1ed13e8. Read the comment docs.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better.

@emmaai emmaai merged commit 983d612 into develop Mar 22, 2022
@emmaai emmaai deleted the change_failure_status branch March 22, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants