Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuser handling in plugin layer. #8

Merged
merged 5 commits into from
Nov 23, 2021
Merged

Fix fuser handling in plugin layer. #8

merged 5 commits into from
Nov 23, 2021

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Nov 22, 2021

Since the plugin API refactor, the default fuser function has been broken (it was doing nothing instead of filtering out datasets that returned no data in the region of interest). This was picked up by DEAfrica in their S2 geomad semi-annual runs. This PR (plus corresponding tweaks to the opendatacube/datacube_docker repo, coming soon) should fix.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #8 (13e9450) into develop (30833ce) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
+ Coverage    61.43%   61.45%   +0.02%     
===========================================
  Files           19       19              
  Lines         1815     1816       +1     
===========================================
+ Hits          1115     1116       +1     
  Misses         700      700              
Impacted Files Coverage Δ
odc/stats/plugins/_base.py 76.92% <50.00%> (+0.60%) ⬆️
odc/stats/plugins/gm.py 68.00% <66.66%> (ø)
odc/stats/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30833ce...13e9450. Read the comment docs.

@omad omad merged commit b2a7f6b into develop Nov 23, 2021
@omad omad deleted the gm_s2_tweaks branch November 23, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants