Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the S2 GM to integration test case #93

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

supermarkion
Copy link
Contributor

Add the DEA S2 GeoMED test case to odc-stats integration test.

The DEA S2 GM can only work with the following cfg file: https://raw.githubusercontent.com/GeoscienceAustralia/dea-config/feature/add-S2ab-GM-processing-cfg/dev/services/odc-stats/geomedian/ga_s2ab_gm_4fyear_3.yaml. In this config file, it use DEA S2 ARD band names, use oa_s2cloudless_mask as Quality Control mask with 0 dilation.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f913cfd) 75.59% compared to head (f80c6f9) 75.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #93   +/-   ##
========================================
  Coverage    75.59%   75.59%           
========================================
  Files           33       33           
  Lines         3175     3175           
========================================
  Hits          2400     2400           
  Misses         775      775           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as you uploaded your geotiff (to be compared to against) to s3

@supermarkion supermarkion merged commit bae67b7 into develop Apr 21, 2023
@supermarkion supermarkion deleted the feature/add-S2ab-GM-case-to-integration-test branch April 21, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants