Merge pull request #24 from opendatadiscovery/chore/field_oddrn

chore: removed redundant field_oddrn parameter
opendatadiscovery · Oct 31, 2023 · 89f8e10 · 89f8e10
2 parents c1967ac + 3c8682b
commit 89f8e10
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/odd_collector_profiler/datasource/database/profiler.py b/odd_collector_profiler/datasource/database/profiler.py
@@ -40,7 +40,7 @@ def get_statistics(self) -> DatasetStatisticsList:
             fields = {}
             for field_stat in profile:
                 field_oddrn = self.get_field_oddrn(field_stat)
-                fields[field_oddrn] = field_stat.to_odd(oddrn=field_oddrn)
+                fields[field_oddrn] = field_stat.to_odd()
             items.append(DataSetStatistics(dataset_oddrn=dataset_oddrn, fields=fields))
 
         return DatasetStatisticsList(items=items)

diff --git a/odd_collector_profiler/domain/statistics/column_statistic.py b/odd_collector_profiler/domain/statistics/column_statistic.py
@@ -13,6 +13,6 @@ def __init__(
         self.column_name = column_name
         self.tags = tags or []
 
-    def to_odd(self, oddrn: str) -> DataSetFieldStat:
+    def to_odd(self) -> DataSetFieldStat:
         tags = [Tag(name=name) for name in self.tags]
-        return DataSetFieldStat(tags=tags, field_oddrn=oddrn)
+        return DataSetFieldStat(tags=tags)
diff --git a/odd_collector_profiler/domain/statistics/datetime_column_statistics.py b/odd_collector_profiler/domain/statistics/datetime_column_statistics.py
@@ -23,8 +23,8 @@ def __init__(
         self.nulls_count = nulls_count
         self.unique_count = unique_count
 
-    def to_odd(self, oddrn: str) -> DataSetFieldStat:
-        data_entity = super().to_odd(oddrn)
+    def to_odd(self) -> DataSetFieldStat:
+        data_entity = super().to_odd()
         data_entity.datetime_stats = DateTimeFieldStat(
             low_value=self.low_value.replace(tzinfo=pytz.utc).isoformat(),
             high_value=self.high_value.replace(tzinfo=pytz.utc).isoformat(),

diff --git a/odd_collector_profiler/domain/statistics/int_column_statistics.py b/odd_collector_profiler/domain/statistics/int_column_statistics.py
@@ -25,8 +25,8 @@ def __init__(
         self.nulls_count = nulls_count
         self.unique_count = unique_count
 
-    def to_odd(self, oddrn: str) -> DataSetFieldStat:
-        data_entity = super().to_odd(oddrn)
+    def to_odd(self) -> DataSetFieldStat:
+        data_entity = super().to_odd()
         data_entity.integer_stats = IntegerFieldStat(
             low_value=self.low_value,
             high_value=self.high_value,

diff --git a/odd_collector_profiler/domain/statistics/number_column_statistics.py b/odd_collector_profiler/domain/statistics/number_column_statistics.py
@@ -25,8 +25,8 @@ def __init__(
         self.nulls_count = nulls_count
         self.unique_count = unique_count
 
-    def to_odd(self, oddrn: str) -> DataSetFieldStat:
-        data_entity = super().to_odd(oddrn)
+    def to_odd(self) -> DataSetFieldStat:
+        data_entity = super().to_odd()
         data_entity.number_stats = NumberFieldStat(
             low_value=self.low_value,
             high_value=self.high_value,

diff --git a/odd_collector_profiler/domain/statistics/string_column_statistics.py b/odd_collector_profiler/domain/statistics/string_column_statistics.py
@@ -21,8 +21,8 @@ def __init__(
         self.nulls_count = nulls_count
         self.unique_count = unique_count
 
-    def to_odd(self, oddrn: str) -> DataSetFieldStat:
-        data_entity = super().to_odd(oddrn)
+    def to_odd(self) -> DataSetFieldStat:
+        data_entity = super().to_odd()
         data_entity.string_stats = StringFieldStat(
             max_length=self.max_length,
             avg_length=round(self.avg_length),