Skip to content

Commit

Permalink
chore: enable spellcheck for md editor (#1683)
Browse files Browse the repository at this point in the history
  • Loading branch information
AndreyNenashev committed May 30, 2024
1 parent 5ca558b commit 1d7675c
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 23 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useMemo, useState } from 'react';
import React, { useMemo } from 'react';
import { Box, Grid, Typography } from '@mui/material';
import { useGetQueryExampleDetails } from 'lib/hooks/api/dataModelling/queryExamples';
import { useAppDateTime } from 'lib/hooks';
Expand Down Expand Up @@ -67,9 +67,7 @@ const QueryExampleDetailsContainer: React.FC = () => {
<Grid item alignItems='center'>
<QueryExampleDetailsTabs
linkedEntitiesHint={queryExampleDetails?.linkedEntities.pageInfo.total}
linkedTermsHint={
queryExampleDetails?.linkedTerms?.items ? queryExampleDetails?.linkedTerms?.items.length : 0
}
linkedTermsHint={queryExampleDetails?.linkedTerms?.items.length}
/>
</Grid>
<Grid item container gap={2} flexDirection='column' alignItems='start'>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Grid, Typography } from '@mui/material';
import { Grid } from '@mui/material';
import React, { useMemo, type FC } from 'react';
import { Markdown, SkeletonWrapper } from 'components/shared/elements';
import { SkeletonWrapper } from 'components/shared/elements';
import { Permission, PermissionResourceType } from 'generated-sources';
import { WithPermissionsProvider } from 'components/shared/contexts';
import { useTermsRouteParams } from 'routes';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ export const Definition = styled('div')(({ theme }) => ({
display: 'flex',
alignItems: 'center',
marginBottom: theme.spacing(1),
}));
}));
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import React, { type FC } from 'react';
import { Box, Grid, Typography } from '@mui/material';
import { WithPermissions } from 'components/shared/contexts';
import { Typography } from '@mui/material';
import type { TermRef } from 'generated-sources';
import { Permission } from 'generated-sources';
import { AppTooltip, Button, Markdown } from 'components/shared/elements';
import { AppTooltip, Markdown } from 'components/shared/elements';
import { useTermWiki } from 'lib/hooks';
import { updateDataSetFieldDescription } from 'redux/thunks';
import { InformationIcon, StrokedInfoIcon } from 'components/shared/icons';
import { InformationIcon } from 'components/shared/icons';
import * as S from './TermDefinition.styles';

interface TermDefinitionProps {
Expand All @@ -16,14 +14,13 @@ interface TermDefinitionProps {
}

const TermDefinition: FC<TermDefinitionProps> = ({ definition, termId, terms }) => {
const { error, internalDescription, transformDescriptionToMarkdown, editMode } =
useTermWiki({
terms,
description: definition,
entityId: termId,
updateDescription: updateDataSetFieldDescription,
isDatasetField: false,
});
const { transformDescriptionToMarkdown } = useTermWiki({
terms,
description: definition,
entityId: termId,
updateDescription: updateDataSetFieldDescription,
isDatasetField: false,
});

const tooltipInfoContent = (
<S.Tooltip>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { type FC, type ReactNode, type CSSProperties } from 'react';
import React, { type FC, type ReactNode, type CSSProperties, useEffect } from 'react';
import type { ContextStore } from '@uiw/react-md-editor';
import MDEditor from '@uiw/react-md-editor';
import type { Position } from 'unist';
Expand Down Expand Up @@ -87,8 +87,16 @@ const Markdown: FC<MarkdownProps> = ({
'data-color-mode'?: 'light' | 'dark';
};

useEffect(() => {
document
.getElementById('md-editor')
?.querySelector('textarea')
?.setAttribute('spellcheck', 'true');
}, []);

return editor ? (
<MDEditor
id='md-editor'
height={height}
value={value}
preview='edit'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,3 @@ export function useGetQueryExamplesByTermId({
queryFn: async () => queryExampleApi.getQueryExampleByTermId({ termId }),
});
}

2 changes: 1 addition & 1 deletion odd-platform-ui/src/lib/hooks/api/terms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export function useUnassignTermQueryExample() {
mutationKey: ['unassignTermQueryExample'],
mutationFn: async ({
exampleId,
termId
termId,
}: TermApiDeleteQueryExampleToTermRelationshipRequest) =>
termApi.deleteQueryExampleToTermRelationship({
termId,
Expand Down

0 comments on commit 1d7675c

Please sign in to comment.