Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new Query Example permission policy #1568

Closed
Vladysl opened this issue Jan 2, 2024 · 2 comments · Fixed by #1633
Closed

Create new Query Example permission policy #1568

Vladysl opened this issue Jan 2, 2024 · 2 comments · Fixed by #1633
Assignees
@AndreyNenashev @Vladysl @anatolii-yemets
Labels
kind: feature New feature request scope: backend Backend task scope: frontend Frontend task
Milestone
0.24.0

Comments

@Vladysl
Copy link
Contributor

Vladysl commented Jan 2, 2024 •
edited
Loading

Create new Policy QUERY_EXAMPLE
Create new Policy Permissions:
QUERY_EXAMPLE_UPDATE(belongs to QUERY_EXAMPLE),
QUERY_EXAMPLE_DELETE(belongs to QUERY_EXAMPLE),
QUERY_EXAMPLE_DATASET_CREATE(belongs to DATA_ENTITY),
QUERY_EXAMPLE_DATASET_DELETE(belongs to DATA_ENTITY).

Condition field - "queryexample:name"

FE part:

  • host/management/policies - should accept new policy type QUERY_EXAMPLE
  • host/data-modelling/query-examples/{query_example_id}- should perform /api/resource/QUERY_EXAMPLE/{query_example_id}/permissions request to retrieve allowed policies for current user
  • host/dataentities/{data_entity_id}/query-examples - should take allowed policies from /api/resource/DATA_ENTITY/{data_entity_id}/permissions request
  • changed API for create/delete queryExample To Data Entity relations
@Vladysl Vladysl added the kind: feature New feature request label Jan 2, 2024
@Vladysl Vladysl self-assigned this Jan 2, 2024
@RamanDamayeu
Copy link
Contributor

Please, also consider updating documents https://docs.opendatadiscovery.org/configuration-and-deployment/enable-security/authorization

@RamanDamayeu RamanDamayeu added scope: backend Backend task scope: frontend Frontend task labels Jan 17, 2024
@RamanDamayeu RamanDamayeu added this to the 0.24.0 milestone Jan 26, 2024
@anatolii-yemets
Copy link
Contributor

Working branch is https://github.com/opendatadiscovery/odd-platform/tree/1568

anatolii-yemets added a commit that referenced this issue Feb 16, 2024
@anatolii-yemets
chore(odd-platform-api): rename migration (#1568)
27cdc15
anatolii-yemets added a commit that referenced this issue Feb 19, 2024
@anatolii-yemets
feat(odd-platform-api): changed API for create/delete queryExample (#…
e99405b 
…1568)
anatolii-yemets added a commit that referenced this issue Feb 19, 2024
@anatolii-yemets
fix(odd-platform-api): autocomplete should not be open without query (#…
e4f8fae 
…1568)
anatolii-yemets added a commit that referenced this issue Feb 19, 2024
@anatolii-yemets
feat(odd-platform-api): get permission for query-example editing/upda…
2438e34 
…ting (#1568)
anatolii-yemets added a commit that referenced this issue Feb 19, 2024
@anatolii-yemets
fix(odd-platform-api): dataentities query-example permissions (#1568)
37c7ba6
@anatolii-yemets anatolii-yemets mentioned this issue Feb 19, 2024
Merged
anatolii-yemets added a commit that referenced this issue Feb 20, 2024
@anatolii-yemets
chore(odd-platform-api): fix comments (#1568)
5d8259c
anatolii-yemets added a commit that referenced this issue Feb 20, 2024
@anatolii-yemets
chore(odd-platform-api): fix comments (#1568)
d3851b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreyNenashev AndreyNenashev

@Vladysl Vladysl

@anatolii-yemets anatolii-yemets

Labels
kind: feature New feature request scope: backend Backend task scope: frontend Frontend task
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Create new Query Example permission policy opendatadiscovery/odd-platform
4 participants
@AndreyNenashev @RamanDamayeu @Vladysl @anatolii-yemets