Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Resolve serialization console errors. Add data source logo into linage. #1483

Merged
merged 4 commits into from
Oct 25, 2023
Merged

chore: Resolve serialization console errors. Add data source logo into linage. #1483

merged 4 commits into from
Oct 25, 2023

Conversation

AndreyNenashev
Copy link
Contributor

Screenshot 2023-10-24 at 13 39 32

@AndreyNenashev AndreyNenashev requested a review from a team as a code owner October 24, 2023 11:40
@AndreyNenashev AndreyNenashev self-assigned this Oct 24, 2023
@github-actions

This comment has been minimized.

Sign in to view
Vladysl
Vladysl previously approved these changes Oct 24, 2023
View reviewed changes
@AndreyNenashev AndreyNenashev requested a review from a team as a code owner October 24, 2023 15:25
@github-actions

This comment has been minimized.

Sign in to view
Leshe4ka
Leshe4ka previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Leshe4ka Leshe4ka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve serialization console errors 👍 🙂
LGTM 👍

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@AndreyNenashev AndreyNenashev force-pushed the issues/1356 branch 2 times, most recently from d51bd14 to 7d229bf Compare October 24, 2023 16:27
@AndreyNenashev
Copy link
Contributor Author

Resolve serialization console errors 👍 🙂 LGTM 👍

Resolve🙂 not fix. Seems legit🙂

@github-actions

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

[odd-platform-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

  51 files    51 suites   3m 1s ⏱️
238 tests 238 ✔️ 0 💤 0 ❌
266 runs  266 ✔️ 0 💤 0 ❌

Results for commit 16fa8ad.

@AndreyNenashev AndreyNenashev merged commit 518e4ea into main Oct 25, 2023
7 checks passed
@AndreyNenashev AndreyNenashev deleted the issues/1356 branch October 25, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vladysl Vladysl Vladysl approved these changes

@Leshe4ka Leshe4ka Awaiting requested review from Leshe4ka

Assignees

@AndreyNenashev AndreyNenashev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datasource logo into lineage card
3 participants
@AndreyNenashev @Vladysl @Leshe4ka