dependencies: update openapi-generator-cli #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyNenashev
commented
Feb 6, 2024
Comment on lines
-33
to
-38
| | DataEntityClassNameEnum.SET | ||
| | DataEntityClassNameEnum.CONSUMER | ||
| | DataEntityClassNameEnum.TRANSFORMER | ||
| | DataEntityClassNameEnum.INPUT | ||
| | DataEntityClassNameEnum.ENTITY_GROUP | ||
| | DataEntityClassNameEnum.QUALITY_TEST |
There was a problem hiding this comment.
this used to be enum. Now with the upgraded version, openapi generates const
AndreyNenashev
commented
Feb 6, 2024
Comment on lines
-115
to
+120
| type={ | ||
| metadataType && | ||
| [MetadataFieldType.INTEGER, MetadataFieldType.FLOAT].includes(metadataType) | ||
| ? 'number' | ||
| : 'text' | ||
| } | ||
| type={metadataType && inputTypes.includes(metadataType) ? 'number' : 'text'} |
There was a problem hiding this comment.
type resolving.
[MetadataFieldType.INTEGER, MetadataFieldType.FLOAT] will be ("INTEGER" | "FLOAT")[] type but we need MetadataFieldType[]
This comment has been minimized.
This comment has been minimized.
anatolii-yemets
previously approved these changes
Feb 7, 2024
AndreyNenashev
force-pushed
the
openapi/update-generator
branch
from
a5d18ad
to
1f58d9c
Compare
anatolii-yemets
previously approved these changes
Feb 7, 2024
anatolii-yemets
approved these changes
Feb 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are heavily by restricted by openapi generator. Need to update it some we can use more features from openapi specification