Hide "Sync your account with existing owner" with no authentication method configured #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladysl
approved these changes
Feb 14, 2024
|
|
AndreyNenashev
approved these changes
Feb 14, 2024
Comment on lines
+25
to
+27
| const isShowOwnerAssociation = Boolean( | ||
| appInfo?.authType && appInfo.authType !== 'DISABLED' | ||
| ); |
There was a problem hiding this comment.
nit: it's a good practice to use useMemo hook for that types of variables but it's not necessary in that particular case. And it seems we don't need data type coercion here
Suggested change
| const isShowOwnerAssociation = Boolean( | |
| appInfo?.authType && appInfo.authType !== 'DISABLED' | |
| ); | |
| const isShowOwnerAssociation = useMemo(() => | |
| appInfo?.authType && appInfo.authType !== 'DISABLED', | |
| [appInfo?.authType]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue where a user receives a 500 Internal Server Error for owner association requests when trying to "Sync your account with existing owner" with no authentication method configured. The functionality is now disabled if no authentication method is provided in the config.
authType: DISABLED
authType: other options
Fixes #1380