Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Results: Add support for entities of type Data Quality #47

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Search: Results: Add support for entities of type Data Quality #47

merged 4 commits into from
Aug 12, 2021

Conversation

Leshe4ka
Copy link
Contributor

@Leshe4ka Leshe4ka commented Jul 23, 2021 •
edited by soffest
Loading

Is Blocked by Backend

Added support for entities of type Data Quality
Refactored ResultItem, decomposing some code to ResultItemTruncatedCell coomponent.

@Leshe4ka Leshe4ka added the WIP label Jul 23, 2021
@Leshe4ka Leshe4ka self-assigned this Jul 23, 2021
@Leshe4ka Leshe4ka linked an issue Jul 23, 2021 that may be closed by this pull request
Search: Results: Add support for entities of type Data Quality #18
Closed
soffest
soffest approved these changes Jul 23, 2021
View reviewed changes
Copy link

@soffest soffest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@DementevNikita DementevNikita self-requested a review July 30, 2021 11:38
@DementevNikita
Copy link
Member

@Leshe4ka,
image

  1. 'Entities' column must show entities that are linked to the DataQualityTest
  2. Please fix type 'Suit URL' -> 'Suite URL'

@Leshe4ka
Copy link
Contributor Author

@Leshe4ka,
image

  1. 'Entities' column must show entities that are linked to the DataQualityTest
  2. Please fix type 'Suit URL' -> 'Suite URL'

dataset_list comes null from backend...

@github-actions github-actions bot added the kind: enhancement Enhancement of existing feature label Jul 30, 2021
@soffest soffest changed the title Search: Results: Add support for entities of type Data Quality WIP: Search: Results: Add support for entities of type Data Quality Aug 10, 2021
@soffest soffest added the scope: frontend Frontend task label Aug 10, 2021
@Leshe4ka Leshe4ka removed the WIP label Aug 12, 2021
@Leshe4ka Leshe4ka changed the title WIP: Search: Results: Add support for entities of type Data Quality Search: Results: Add support for entities of type Data Quality Aug 12, 2021
@Leshe4ka Leshe4ka merged commit 5cc08cc into main Aug 12, 2021
@Leshe4ka Leshe4ka deleted the feature/search_results_dataQA branch August 12, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DementevNikita DementevNikita Awaiting requested review from DementevNikita

@soffest soffest Awaiting requested review from soffest

Assignees

@Leshe4ka Leshe4ka

Labels
kind: enhancement Enhancement of existing feature scope: frontend Frontend task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search: Results: Add support for entities of type Data Quality
3 participants
@Leshe4ka @DementevNikita @soffest