This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Update JH dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavlin
force-pushed
the
feature/openshift
branch
from
5e1d4b5
to
d1e10a8
Compare
|
It looks good but I wanted to check and see how this image should be built. This upstream repo provided the base image that we used for building jupyterhub-ocp-oauth. Are there additional changes needed in jupyterhub-ocp-oauth? |
vpavlin
changed the title
|
I found a couple of issues, so adding WIP for now |
|
The env var changes in this could be replaced by jupyterhub/oauthenticator#363 if it gets merged |
vpavlin
force-pushed
the
feature/openshift
branch
from
5105d42
to
24ca386
Compare
vpavlin
force-pushed
the
feature/openshift
branch
from
24ca386
to
df2f56a
Compare
vpavlin
changed the title
|
@LaVLaS This is ready now |
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were originally set in jupyterhub_config-workspace only, but they'd be useful even for the default installation. In addition Open Data Hub depends onOPENSHIFT_URLto be set for OAuth, so it makes sense to set them alwaysThere is a PR against oauthenticator (jupyterhub/oauthenticator#363) which fixes some of the issues with OpenShift. Leaving this repo without changes and I'll install the updated version of oauthenticator in jupyterhub-odh (jupyterhub-ocp-oauth)