Skip to content

Commit

Permalink
feat: kserve task now has option for self signed cert
Browse files Browse the repository at this point in the history
  • Loading branch information
jackdelahunt committed Apr 3, 2024
1 parent 78596f2 commit 587fd14
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 2 deletions.
13 changes: 12 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
MAKE_ENV_FILE = local.vars.mk
-include $(MAKE_ENV_FILE)

.PHONY: install install/observability-core install/observability-edge test-acm-%-generate test go-test go-test-setup
.PHONY: install install/observability-core install/observability-edge test-acm-%-generate test go-test go-test-setup minio

install: install/observability-core install/observability-edge

Expand Down Expand Up @@ -95,3 +95,14 @@ endif
test:
@(./test/shell-pipeline-tests/seldon-bike-rentals/pipelines-test-seldon-bike-rentals.sh)
@(./test/shell-pipeline-tests/openvino-tensorflow-housing/pipelines-test-openvino-tensorflow-housing.sh)

minio:
ifndef MINIO
$(error MINIO is undefined)
endif
oc new-project minio
oc create secret tls minio-tls --cert=../certs/minio.crt --key=../certs/minio.key
oc apply -f ${MINIO}
oc expose deployment minio-deployment --port=9000 --type=NodePort --name=minio-deployment-s3
oc expose service minio-deployment-s3

2 changes: 2 additions & 0 deletions pipelines/tekton/aiedge-e2e/aiedge-e2e.pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ spec:
workspace: build-workspace-pv
- name: s3-secret
workspace: s3-secret
- name: ssl-ca-directory
workspace: ssl-certs
when:
- input: "$(params.fetch-model)"
operator: in
Expand Down
9 changes: 8 additions & 1 deletion pipelines/tekton/aiedge-e2e/tasks/kserve-download-model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,14 @@ spec:
- name: download-model-s3
image: quay.io/opendatahub/kserve-storage-initializer:v0.11
script: |
mkdir -p $(workspaces.workspace.path)/model_dir-$(params.model-name)/
mkdir -p $(workspaces.workspace.path)/model_dir-$(params.model-name)/
export S3_URL="s3://$(params.s3-bucket-name)/$(params.model-name)"
echo -n $S3_URL | tee $(results.s3-url.path) ;
export CA_BUNDLE_CONFIGMAP_NAME=self-signed-cert
export CA_BUNDLE_VOLUME_MOUNT_POINT=$(workspaces.ssl-ca-directory.path)
STORAGE_CONFIG="$(cat $(workspaces.s3-secret.path)/s3-storage-config)" /storage-initializer/scripts/initializer-entrypoint \
$S3_URL \
$(workspaces.workspace.path)/model_dir-$(params.model-name)/$(params.model-name)
Expand All @@ -32,3 +35,7 @@ spec:
name: workspace
- description: The S3 secret.
name: s3-secret
- description: |
A workspace containing CA certificates, this will be used by Git to
verify the peer with when fetching or pushing over HTTPS.
name: ssl-ca-directory

0 comments on commit 587fd14

Please sign in to comment.