Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scripts/doc for mtls=true, refactorying script structure #106

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Oct 13, 2023

Description

This PR fixes the following issues:

How Has This Been Tested?

script check

odh installation

git clone --branch 20231011_doc_update git@github.com:Jooho/caikit-tgis-serving.git
cd caikit-tgis-serving/demo/kserve
export TARGET_OPERATOR=odh 
export CHECK_UWM=false

./scripts/install/kserve-install.sh
./scripts/test/deploy-model.sh
./scripts/test/grpc-call.sh

# Verify this use mtls: true
oc get smcp -o yaml minimal -n istio-system|grep mtls
...
        mtls: true
...

./scripts/uninstall/kserve-uninstall.sh
./scripts/uninstall/dependencies-uninstall.sh

rhods installation

export TARGET_OPERATOR=rhods
export CHECK_UWM=false

./scripts/install/kserve-install.sh
./scripts/test/deploy-model.sh
./scripts/test/grpc-call.sh

# Verify this use mtls: true
oc get smcp -o yaml minimal -n istio-system|grep mtls
...
        mtls: true
...

./scripts/uninstall/kserve-uninstall.sh
./scripts/uninstall/dependencies-uninstall.sh

New variable DEPLOY_ODH_OPERATOR

export TARGET_OPERATOR=odh 
export CHECK_UWM=false

DEPLOY_ODH_OPERATOR=false ./scripts/install/kserve-install.sh

# Check this msg
[INFO] Deploy odh operator

DEPLOY_ODH_OPERATOR set false. Skip deploy odh/rhods operator  <== 
[INFO] Create DataScienceCluster

Error from server (NotFound): datascienceclusters.datasciencecluster.opendatahub.io "default" not found
...

Doc check
Follow this doc to install kserve
https://github.com/Jooho/caikit-tgis-serving/blob/20231011_doc_update/demo/kserve/install-manual.md

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…rt custom cert

Signed-off-by: jooho <jlee@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 86d2a66 into opendatahub-io:main Oct 18, 2023
2 checks passed
@spolti spolti changed the title update scripts/doc for mtls=true, refactorying sript structure update scripts/doc for mtls=true, refactorying script structure Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants