Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push artifact work around. #212

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Jul 24, 2023

Resolves: #214

Description

The workaround identifies artifacts in workspace and pushes them to s3 storage.

How Has This Been Tested?

On live ocp cluster. Run pipeline and confirm artifacts are stored in s3 when doing data passing, or save to output path.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive July 24, 2023 12:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK added the qe/verify Labels to inform qe on issues to verify. label Jul 24, 2023
The workaround identifies artifacts in workspace and pushes them to s3
storage.

Signed-off-by: Humair Khan <humair88@hotmail.com>
@gregsheremeta
Copy link
Contributor

/lgtm
/approve

i tested it, works great

@HumairAK HumairAK merged commit 7527318 into opendatahub-io:main Jul 27, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe/verify Labels to inform qe on issues to verify.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

artifact upload to object storage from the last step in a pipeline doesn't work
2 participants