Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy mariadb nwp with mariadb #647

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

HumairAK
Copy link
Collaborator

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-5314

Description of your changes:

ensures the NWP is deployed along with mariadb, otherwise the DSPO will attempt to verify connection to mariadb without the nwp.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from amadhusu and gmfrasca May 10, 2024 18:56
@dsp-developers
Copy link
Collaborator

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-647
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/647/head
git checkout -b pullrequest 7ac94f5c0f01684f197543fedcdc99ede3f96533
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-647"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@VaniHaripriya VaniHaripriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Just nit pick change- Please update networkpolicy name instead of newtorkpolicy

@HumairAK
Copy link
Collaborator Author

@VaniHaripriya the naming is consistent with the other files in the directory

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Copy link
Collaborator Author

nvm I noticed the typo, updated

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dharmitd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaniHaripriya
Copy link
Contributor

/lgtm

@dsp-developers
Copy link
Collaborator

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-647

@HumairAK HumairAK merged commit d8e0b68 into opendatahub-io:main May 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants