Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove helper method to set image pull policy #11

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rkpattnaik780
Copy link

@rkpattnaik780 rkpattnaik780 commented Apr 9, 2024

This PR removes the helper function that sets the image pull policy for a task.
The error was caused due to image_policy not being defined in kubernetes_executor_config_pb2 in the latest release.

Related-to: https://issues.redhat.com/browse/RHOAIENG-5069

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@harshad16 harshad16 merged commit 1b41943 into opendatahub-io:kfpv2 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants