Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute back to upstream changes in Dockerfiles #48

Closed
israel-hdez opened this issue Aug 3, 2023 · 1 comment
Closed

Contribute back to upstream changes in Dockerfiles #48

israel-hdez opened this issue Aug 3, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@israel-hdez
Copy link

As part of enabling E2E tests in openshift-ci, two Dockerfiles were changed:

If possible, these two changes should be contributed back to upstream, to minimize code diversion. In upstream, these changes should have no effect, but given that in openshift-ci a different base image is configured, the introduced flag is allowing the build to succeed.
@israel-hdez israel-hdez mentioned this issue Aug 3, 2023
Merged
@israel-hdez israel-hdez added the good first issue Good for newcomers label Aug 25, 2023
@israel-hdez
Copy link
Author

Moved to: https://issues.redhat.com/browse/RHOAIENG-1011

@israel-hdez israel-hdez closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
Jooho pushed a commit to Jooho/kserve that referenced this issue Jan 11, 2024
@VedantMahabaleshwarkar
Merge pull request opendatahub-io#48 from Jooho/odh-op-2.0
ed322c4 
Remove kfdef for monitoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@israel-hdez