Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syntax error in inferenceservice-config patch #257

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix syntax error in inferenceservice-config patch #257

merged 1 commit into from
Feb 29, 2024

Conversation

VedantMahabaleshwarkar
Copy link

Fixing a missing comma from #251

@VedantMahabaleshwarkar
fix syntax error in inferenceservice-config patch
fcc28b1 
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
terrytangyuan
terrytangyuan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielezonca, terrytangyuan, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,danielezonca,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VedantMahabaleshwarkar
Copy link
Author

/override ci/prow/e2e-fast ci/prow/e2e-slow

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024

@VedantMahabaleshwarkar: Overrode contexts on behalf of VedantMahabaleshwarkar: ci/prow/e2e-fast, ci/prow/e2e-slow

In response to this:

/override ci/prow/e2e-fast ci/prow/e2e-slow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VedantMahabaleshwarkar
Copy link
Author

overriding e2e test failures as they are unrelated and seem to be due to infra issues
cc @israel-hdez

@openshift-merge-bot openshift-merge-bot bot merged commit 3a781f5 into opendatahub-io:master Feb 29, 2024
28 checks passed
@VedantMahabaleshwarkar VedantMahabaleshwarkar mentioned this pull request Feb 29, 2024
Merged
@israel-hdez israel-hdez mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielezonca danielezonca danielezonca approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@israel-hdez israel-hdez Awaiting requested review from israel-hdez

Assignees

@danielezonca danielezonca

@terrytangyuan terrytangyuan

Labels
approved lgtm
Projects
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VedantMahabaleshwarkar @danielezonca @terrytangyuan