Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-5073] - Routing and Headless Service Support in KServe Raw … #280

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Apr 2, 2024

…Mode Deployment

What this PR does / why we need it:

Raw Deployments need to be fronted by a routing component. Currently, the FMaaS/Rust router (and Caikit) client-side load balance and proxy requests across a model deployment's pods/replica's. To do so they utilizes a Headless service that sits in between itself and the replica's, queries addresses to the physical pods, and round robins requests.

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Release note:

NONE

…Mode Deployment

Signed-off-by: Spolti <fspolti@redhat.com>
@spolti
Copy link
Member Author

spolti commented Apr 3, 2024

The raw succeeded here #272
Wondering what might be happening.
Does the logging behaves differently when using ClusterIP: None?

@terrytangyuan @Jooho

@spolti
Copy link
Member Author

spolti commented Apr 3, 2024

/retest e2e-raw

Copy link

openshift-ci bot commented Apr 3, 2024

@spolti: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-fast
  • /test e2e-raw
  • /test e2e-slow
  • /test images
  • /test pr-image-mirror-kserve-agent
  • /test pr-image-mirror-kserve-controller
  • /test pr-image-mirror-kserve-router
  • /test pr-image-mirror-kserve-storage-initializer

Use /test all to run all jobs.

In response to this:

/retest e2e-raw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Member Author

spolti commented Apr 3, 2024

/test e2e-raw

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [spolti,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants