Commits on Jul 27, 2023

1. Onboarding on openshift-ci …

   These are the needed changes to have openshift-ci running the E2E tests successfully.
   
   There are several groups of E2E tests that can be deduced from the .github/workflows/e2e-test.yaml file: fast, slow, explainer, transformer-mms, qpext, grpc, helm, raw and kourier. For ODH, the `fast`, `slow` and `grpc` groups are the ones that cover the features that are going to be supported in the initial adoption of ODH.
   
   This commit contains the needed adaptations to the E2E tests of the `fast` and `slow` groups to successfully run them in an openshift cluster. It also adds a few scripts on test/scripts/openshift-ci to run these E2Es in the openshift-ci operator.
   
   Some of these changes should be seen as provisional and should be rolled back:
   * test/e2e/common/utils.py: because of the networking/DNS expectations, that are currently not covered in ODH's installation.
   * test/e2e/predictor/*:
     * In general all changes under this path should be seen as provisional. However, since ODH won't support all ServingRuntimes, it is possible that some of the tests will stay out.
     * There are some GRPC-related tests marked as skipped. Since this work is not enabling the `grpc` group, a subsequent commit/PR for enabling GRPC E2Es should remove/revert those skip marks.
     * Also, there are some tests skipped with the `Not testable in ODH at the moment` reason. The root cause of the failure should be investigated to re-enable these tests.
   * python/kserve/kserve/models/v1beta1_inference_service.py: This is injecting an annotation that is required given the specifics of OSSM/Maistra and OpenShift-Serverless that are used in ODH. This annotation is, currently, user responsibility and this was the cleanest way to add it in the E2Es. Being platform-specific, it's been discussed that this (and some other) annotation should be injected by some controller to relief the user from this responsibility. If this happens, this change should be reverted.
   
   Also, ideally, changes to the following files should be contributed back to upstream. Those changes are not required in upstream and should have no effect, but in openshift-ci become required because a different builder image is being used:
   * Dockerfile
   * agent.Dockerfile
   
   Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>

   

   israel-hdez committed Jul 27, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for ecff079
   • Browse repository at this point

   Copy the full SHA

   ecff079 View commit details

   Browse the repository at this point in the history