Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: Catch the configmap notfound and logged #272

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

harshad16
Copy link
Member

HotFix: Catch the configmap notfound and logged

Description

Related-to: https://issues.redhat.com/browse/RHOAIENG-4165

If the configmap is not present , it complains about:
"configMap":"odh-trusted-ca-bundle","error":"ConfigMap \"odh-trusted-ca-bundle\" not found","stacktrace":"...

How Has This Been Tested?

  1. Use the PR image in deployment.
  2. Create a notebook in a namespace without odh-trusted-ca-bundle configmap
  3. check for the error

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit f410732 into opendatahub-io:v1.7-branch Mar 12, 2024
2 of 6 checks passed
@harshad16
Copy link
Member Author

/cherrypick stable

@openshift-cherrypick-robot

@harshad16: new pull request created: #273

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants