fix: add GIT_SSL_CAINFO env variable in odh-notebook-controller #327
Conversation
| @@ -375,7 +375,7 @@ func (r *OpenshiftNotebookReconciler) UnsetNotebookCertConfig(notebook *nbv1.Not | |||
| log := r.Log.WithValues("notebook", notebook.Name, "namespace", notebook.Namespace) | |||
|
|
|||
| // Get the notebook object | |||
| envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS"} | |||
| envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS", "GIT_SSL_CAINFO"} | |||
There was a problem hiding this comment.
How is this variable different from GIT_SSL_CAPATH. Looking at https://git-scm.com/docs/git-config#Documentation/git-config.txt-httpsslCAInfo, I can't make sense of it.
There was a problem hiding this comment.
Aha, got it, one is to provide a single pem file and the other to provide directory of pem files.
|
/test odh-notebook-controller-pr-image-mirror |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 739d427
into
opendatahub-io:v1.7-branch
|
/cherrypick stable |
|
@harshad16: new pull request created: #328 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes RHOAIENG-6410.
Description
This PR adds environment variable to the
odh-notebook-controllerHow Has This Been Tested?
Able to see the environemnet variable mounted for the notebook pod:
Merge criteria: