Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for MySQL database, fixes RHOAIENG-3246, RHOAIENG-3247 #60

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

How Has This Been Tested?

Unit test updated to test both DB configs.
Tested locally by using the updated mysql and postgres samples.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@tarilabs tarilabs mentioned this pull request Feb 16, 2024
@dhirajsb
Copy link
Contributor Author

MySQL test is timing out. Will take a look in the morning.

…se config, fixed handling errors when deleting
@dhirajsb
Copy link
Contributor Author

For some reason the mysql DB in the ci Kind cluster fails to start with the error:

mysqladmin: connect to server at 'localhost' failed
error: 'Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)'
Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists!

But the same mysql 8.3.0 image runs fine in a local Kind cluster and a ROSA OpenShift cluster.
I've switched the test back to using postgres so that this Kind test for CI can pass. It still exercises the operator template changes so it's a valid test.

@dhirajsb dhirajsb requested a review from a team February 19, 2024 23:35
Copy link
Contributor

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhirajsb dhirajsb merged commit c0eba76 into opendatahub-io:main Feb 20, 2024
2 checks passed
@dhirajsb dhirajsb deleted the mysql-db branch February 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants