Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Profiling feature to get debug data for modelmesh controller. #102

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Jooho
Copy link
Collaborator

@Jooho Jooho commented May 23, 2023

Motivation

Modelmesh Controller has a memory leak issue(https://issues.redhat.com/browse/RHODS-8868) so it needs to gather heapdump. In order to get detailed data, net/http/pprof package should be added.

This change will deploy a webserver and it provides to download data but this web server requires authentication to download debugging data.

Modifications

Added pprof package.

Test

Add ENABLE_PPROF environmental variable in the odh-modelmesh-controller deployment.

oc port-forward pod/modelmesh-controller-XXXX  9999:9999
http://localhost:9999/debug/pprof/heap

Result

heap file will be downloaded.

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

Signed-off-by: jooho <jlee@redhat.com>
@Jooho
Copy link
Collaborator Author

Jooho commented Jun 9, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a1b90ac into opendatahub-io:main Jun 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants