Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive pytorch back from cuda data science notebook #112

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Derive pytorch back from cuda data science notebook #112

merged 1 commit into from
Jun 15, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 8, 2023

Fix for #75

Should be merged first the PR on the CI: openshift/release#40199

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 linked an issue Jun 8, 2023 that may be closed by this pull request
Derive PyTorch notebook back from cuda data science #75
Closed
@atheo89
Copy link
Member Author

atheo89 commented Jun 12, 2023

/retest-required

@atheo89 atheo89 mentioned this pull request Jun 15, 2023
Closed
harshad16
harshad16 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Jun 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

/retest-required

3 similar comments
@atheo89
Copy link
Member Author

atheo89 commented Jun 15, 2023

/retest-required

@atheo89
Copy link
Member Author

atheo89 commented Jun 15, 2023

/retest-required

@atheo89
Copy link
Member Author

atheo89 commented Jun 15, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 3f835fb into opendatahub-io:main Jun 15, 2023
33 checks passed
atheo89 added a commit to atheo89/notebooks that referenced this pull request Jun 15, 2023
@atheo89
Derive pytorch back from cuda data science notebook (opendatahub-io#112)
29793df
atheo89 added a commit to atheo89/notebooks that referenced this pull request Jun 15, 2023
@atheo89
Derive pytorch back from cuda data science notebook (opendatahub-io#112)
8985e0c
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Sep 27, 2023
@atheo89 @harshad16
Derive pytorch back from cuda data science notebook (opendatahub-io#112)
22d6753
atheo89 pushed a commit to atheo89/notebooks that referenced this pull request Jan 24, 2024
@harshad16
Merge pull request opendatahub-io#112 from red-hat-data-services/dige…
a6d02f6 
…st-updater-7533330854

[Digest Updater Action] Update notebook's imageStreams image tag to digest format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derive PyTorch notebook back from cuda data science
3 participants
@atheo89 @harshad16 @openshift-merge-robot