-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating package versions for notebook test #284
Conversation
Thanks, Diamond for your fix, the changes in the Minimal, Data Science, and PyTorch in both ubi8/9 flavors look good. However, we need to update also the TensorFlow ubi8/9 (change the version from 2.11 to 2.13). Moreover, I switched the branch that this PR was pointing out from 2023b to main. For two reasons: The first is that the e2e tests take place only on the main branch (development branch), and the second is that the flow is first to main and then we sync the release branch 2023b. The 2023b branch is not a feature branch anymore. |
okay thank you! and with tensorflow on my docs and pipfile it only has 2.11 and not 13. should I still update this? |
Yes, probably your branch wasn't synced. This is the latest update: link Thank you for incorporating the changes on TensorFlow test notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/notebooks-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes for #192
Description
I updated some of the package versions in minimal, data science and pytorch notebooks.
How Has This Been Tested?
Merge criteria: