Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating package versions for notebook test #284

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

dibryant
Copy link
Contributor

fixes for #192

Description

I updated some of the package versions in minimal, data science and pytorch notebooks.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 changed the base branch from 2023b to main October 26, 2023 08:54
@atheo89
Copy link
Member

atheo89 commented Oct 26, 2023

Thanks, Diamond for your fix, the changes in the Minimal, Data Science, and PyTorch in both ubi8/9 flavors look good. However, we need to update also the TensorFlow ubi8/9 (change the version from 2.11 to 2.13).

Moreover, I switched the branch that this PR was pointing out from 2023b to main. For two reasons: The first is that the e2e tests take place only on the main branch (development branch), and the second is that the flow is first to main and then we sync the release branch 2023b. The 2023b branch is not a feature branch anymore.

@dibryant
Copy link
Contributor Author

Thanks, Diamond for your fix, the changes in the Minimal, Data Science, and PyTorch in both ubi8/9 flavors look good. However, we need to update also the TensorFlow ubi8/9 (change the version from 2.11 to 2.13).

Moreover, I switched the branch that this PR was pointing out from 2023b to main. For two reasons: The first is that the e2e tests take place only on the main branch (development branch), and the second is that the flow is first to main and then we sync the release branch 2023b. The 2023b branch is not a feature branch anymore.

okay thank you! and with tensorflow on my docs and pipfile it only has 2.11 and not 13. should I still update this?

@atheo89
Copy link
Member

atheo89 commented Oct 26, 2023

on my docs and pipfile it only has 2.11 and not 13.

Yes, probably your branch wasn't synced. This is the latest update: link

Thank you for incorporating the changes on TensorFlow test notebook

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Oct 26, 2023

/override ci/prow/notebooks-e2e-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit f2b08d1 into opendatahub-io:main Oct 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants