-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebooks-digest-workflow in favor 2024a release #451
Conversation
…pdate the env files accordingly
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The changes look good, is there any diff created from a successful run for quick look? |
Thank you for the review, Rama! Unfortunately, there's no run because we haven't built notebooks from the 2024a branch. As a result, the workflow won't have anything to pick up from 2024a and will eventually fail. |
Thanks for this, looks very neat . /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-4341
Description
This PR updates the notebooks-digest-workflow in favor 2024a release.
PS: It fixes a typo issue on
Fetch digest, and update the commit.env file
for N-1 releaseMerge criteria: