Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks-digest-workflow in favor 2024a release #451

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 11, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-4341

Description

This PR updates the notebooks-digest-workflow in favor 2024a release.

PS: It fixes a typo issue on Fetch digest, and update the commit.env file for N-1 release

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 2af302c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpattnaik780
Copy link
Contributor

The changes look good, is there any diff created from a successful run for quick look?

@atheo89
Copy link
Member Author

atheo89 commented Mar 12, 2024

The changes look good, is there any diff created from a successful run for quick look?

Thank you for the review, Rama! Unfortunately, there's no run because we haven't built notebooks from the 2024a branch. As a result, the workflow won't have anything to pick up from 2024a and will eventually fail.

@harshad16
Copy link
Member

Thanks for this, looks very neat .
lets hold this for the end.
in case, we need to use the digest-updater in this week.

/hold

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit c8e03de into opendatahub-io:main Mar 14, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants