-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VS Code Server Notebook #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty neat
amazing work.
lets remove the entire code-server for centos, we would only rely on ubi9 one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with the UBI9 version of the image and it's working and it resolves several issues in issues.redhat.com that we have there. +1 from me!
@jiridanek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified with the instructions provided.
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jiridanek, rkpattnaik780 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-4345
Moreover seems that solves also this: https://issues.redhat.com/browse/RHOAIENG-2312
NOTE: When I launch a new notebook, the interpreter is already set to /opt/app-root/bin/python3, located in the bottom right corner.
![image](https://private-user-images.githubusercontent.com/42587738/312106524-3bb62c54-ae32-44b6-8440-41f606231a48.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4NTcyNzIsIm5iZiI6MTcyMzg1Njk3MiwicGF0aCI6Ii80MjU4NzczOC8zMTIxMDY1MjQtM2JiNjJjNTQtYWUzMi00NGI2LTg0NDAtNDFmNjA2MjMxYTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDAxMDkzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFjNmQwNTRmZmNkMWNmZWVhYmQ1Y2Y0MDRlZDYzNTk5ZjEyYzc1YzVlNmE1YzQ2MmY0OTQxNzk0NDQ0ZjZhYmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-Tke7YGQukomQ4vkCnllGI6Rlov7Tc_0jQaZD6UzUPo)
Description
This pull request updates the following components:
The codeserver version from
v4.16.1
tov4.22.0
The pre-built extensions
v2023.14.0
tov2024.2.1
v2023.3.100
tov2023.9.100
The pre-built python packages
NOTE: The
kafka-python
library version~=2.0.2
that we preinstall has ceased updates since September 30, 2020. Considering this, should we include it, or would it better to avoid it due to the potential introduction of vulnerabilities in the notebook?Update the codeserver related ImageStream
We drop the n-2 on upstream
How Has This Been Tested?
Way 1
podman run --network=host --name validation-container quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.9-pr-452
Way 2
Merge criteria: