-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Digest Updater Action] Update Notebook Images #541
Conversation
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b6323ff
to
fde5243
Compare
fde5243
to
bac51f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In case that there is an image tag subpart of another tag, there could be wrong tag chosen and as a result wrong SHA used for the manifest update. E.g. these two: * "rstudio-c9s-python-3.9-2024a-20240315-02193dd", * "cuda-rstudio-c9s-python-3.9-2024a-20240315-02193dd", Example of wrong update opendatahub-io#541 (3df148c). Together with this, I also updated the quay security analysis script where is the exact same issue.
In case that there is an image tag subpart of another tag, there could be wrong tag chosen and as a result wrong SHA used for the manifest update. E.g. these two: * "rstudio-c9s-python-3.9-2024a-20240315-02193dd", * "cuda-rstudio-c9s-python-3.9-2024a-20240315-02193dd", Example of wrong update opendatahub-io#541 (3df148c). Together with this, I also updated the quay security analysis script where is the exact same issue.
In case that there is an image tag subpart of another tag, there could be wrong tag chosen and as a result wrong SHA used for the manifest update. E.g. these two: * "rstudio-c9s-python-3.9-2024a-20240315-02193dd", * "cuda-rstudio-c9s-python-3.9-2024a-20240315-02193dd", Example of wrong update opendatahub-io#541 (3df148c). Together with this, I also updated the quay security analysis script where is the exact same issue.
🚀 This is an automated Pull Request.
Created by
/.github/workflows/notebooks-digest-updater-upstream.yaml
This PR updates the following files:
manifests/base/params.env
file with the latest updated SHA digests of the notebooks (N & N-1).manifests/base/commit.env
file with the latest commit (N & N-1).❗ IMPORTANT NOTE: Remember to delete the
digest-updater-9212450078
branch after merging the changes