Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-8299: Fix CentOS Stream 8 download location #554

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-8299

Description

Previously used location is now unavailable and returns 404 error. This is because CentOS Stream 8 has been EOLd

This new location is an archive and is no longer receiving updates.

How Has This Been Tested?

I thought about it really hard and I was very careful, promise. Oh yeah, and I did a podman image build, btw.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and jstourac June 7, 2024 12:11
@jiridanek jiridanek force-pushed the jd_temporary_workaround_centosstream8 branch from be82b7f to 93f0c32 Compare June 7, 2024 12:13
@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@jiridanek jiridanek force-pushed the jd_temporary_workaround_centosstream8 branch from 93f0c32 to 5d406d6 Compare June 7, 2024 12:26
@openshift-ci openshift-ci bot removed the lgtm label Jun 7, 2024
Previously used location is now unavailable and returns 404 error.
This is because CentOS Stream 8 has been EOLd

This new location is an archive and is no longer receiving updates.
@jiridanek jiridanek force-pushed the jd_temporary_workaround_centosstream8 branch from 5d406d6 to 8e19ee2 Compare June 7, 2024 12:53
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@atheo89
Copy link
Member

atheo89 commented Jun 7, 2024

The images built successfully! All set :)

/lgtm
/approve

@jiridanek
Copy link
Member Author

/retest

@jiridanek jiridanek requested a review from harshad16 June 7, 2024 18:50
@jiridanek
Copy link
Member Author

jiridanek commented Jun 8, 2024

Regarding failing e2e tests. The intel image is a beast of almost 15GiB (compressed) and it downloads additional almost 400MiB of samples when it starts. It makes sense that it won't start up quickly, especially on our abused openshift-ci. My home net connection can't take such abuse and I had to switch to running this on a remote machine in Brno. I'll retrigger this a few more times and maybe I'll get lucky

[jdanek@localhost ~]$ podman images
REPOSITORY                                    TAG                                                                                                        IMAGE ID      CREATED       SIZE
ghcr.io/jiridanek/notebooks/workbench-images  jupyter-intel-tensorflow-ubi9-python-3.9-jd_try_dep_inside_nodes_fa89076788d08ff8f167626cfd78407fea720857  97b4d227d359  15 hours ago  14.4 GB
[jdanek@localhost ~]$ time podman run --net=host --rm -it ghcr.io/jiridanek/notebooks/workbench-images:jupyter-intel-tensorflow-ubi9-python-3.9-jd_try_dep_inside_nodes_fa89076788d08ff8f167626cfd78407fea720857
+ APP_ROOT=/opt/app-root
+ '[' -n https://github.com/IntelAI/oneAPI-samples ']'
++ echo https://github.com/IntelAI/oneAPI-samples
++ tr , ' '
+ for repo in `echo ${JUPYTER_PRELOAD_REPOS} | tr ',' ' '`
++ echo https://github.com/IntelAI/oneAPI-samples
++ cut -s -d@ -f2
+ REPO_BRANCH=
+ [[ -n '' ]]
+ echo 'Checking if repository https://github.com/IntelAI/oneAPI-samples exists locally'
Checking if repository https://github.com/IntelAI/oneAPI-samples exists locally
++ basename https://github.com/IntelAI/oneAPI-samples
+ REPO_DIR=oneAPI-samples
+ '[' -d oneAPI-samples ']'
+ GIT_SSL_NO_VERIFY=true
+ git clone https://github.com/IntelAI/oneAPI-samples oneAPI-samples
Cloning into 'oneAPI-samples'...
remote: Enumerating objects: 37899, done.
remote: Counting objects: 100% (1922/1922), done.
remote: Compressing objects: 100% (1073/1073), done.
remote: Total 37899 (delta 987), reused 1470 (delta 800), pack-reused 35977
Receiving objects: 100% (37899/37899), 390.30 MiB | 11.72 MiB/s, done.
Resolving deltas: 100% (24684/24684), done.
+ /opt/app-root/bin/start-notebook.sh

/retest

@jiridanek

This comment was marked as duplicate.

2 similar comments
@jiridanek
Copy link
Member Author

/test notebooks-e2e-tests

@jiridanek
Copy link
Member Author

/test notebooks-e2e-tests

@jiridanek

This comment was marked as duplicate.

7 similar comments
@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@jiridanek

This comment was marked as duplicate.

@atheo89
Copy link
Member

atheo89 commented Jun 10, 2024

/override ci/prow/notebooks-e2e-tests

as it is failing on intel notebook which is not related to habana

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests

as it is failing on intel notebook which is not related to habana

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed22ccd into opendatahub-io:main Jun 10, 2024
7 checks passed
@jiridanek jiridanek deleted the jd_temporary_workaround_centosstream8 branch June 10, 2024 09:03
@jiridanek jiridanek restored the jd_temporary_workaround_centosstream8 branch June 10, 2024 09:12
@jiridanek jiridanek deleted the jd_temporary_workaround_centosstream8 branch June 10, 2024 09:14
@jstourac
Copy link
Member

@jiridanek @harshad16 don't we need this (or at least some parts of this) to backport also for the 2023b branch? 🤔

@jiridanek
Copy link
Member Author

/cherrypick 2023b

@openshift-cherrypick-robot

@jiridanek: #554 failed to apply on top of branch "2023b":

Applying: RHOAIENG-8299: Fix CentOS Stream 8 download location
Using index info to reconstruct a base tree...
A	habana/1.13.0/ubi8-python-3.8/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): habana/1.13.0/ubi8-python-3.8/Dockerfile deleted in HEAD and modified in RHOAIENG-8299: Fix CentOS Stream 8 download location. Version RHOAIENG-8299: Fix CentOS Stream 8 download location of habana/1.13.0/ubi8-python-3.8/Dockerfile left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHOAIENG-8299: Fix CentOS Stream 8 download location
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 15, 2024

/cherrypick 2023a

@openshift-cherrypick-robot

@atheo89: #554 failed to apply on top of branch "2023a":

Applying: RHOAIENG-8299: Fix CentOS Stream 8 download location
Using index info to reconstruct a base tree...
A	habana/1.13.0/ubi8-python-3.8/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): habana/1.13.0/ubi8-python-3.8/Dockerfile deleted in HEAD and modified in RHOAIENG-8299: Fix CentOS Stream 8 download location. Version RHOAIENG-8299: Fix CentOS Stream 8 download location of habana/1.13.0/ubi8-python-3.8/Dockerfile left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHOAIENG-8299: Fix CentOS Stream 8 download location
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick 2023a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 15, 2024

#619
Fixed cherry pick PR for 2023a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants