Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase available disk space for GHA container image builds #577

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jun 21, 2024

Description

This PR creates a LVM overlay, increasing the available disk space for podman builds from previous 66GB

/dev/sda1        74G  4.1G   66G   6% /mnt

to 83GB by default,

/dev/mapper/buildvg-buildlv   83G   24K   83G   1% /home/runner/.local/share/containers

and whopping 102GB when building any amd/cuda/intel/pytorch/tensorflow image!

/dev/mapper/buildvg-buildlv  102G   24K  102G   1% /home/runner/.local/share/containers

This should give us enough disk space to build AMD ROCm images.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work


[storage.options]
# https://www.redhat.com/sysadmin/faster-container-image-pulls
pull_options = {enable_partial_images = "true", use_hard_links = "true", ostree_repos=""}
pull_options = {enable_partial_images = "true", use_hard_links = "false", ostree_repos=""}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_hard_links = "false" is what's shown in the blog

@jiridanek jiridanek requested a review from dibryant June 21, 2024 07:46
@jiridanek jiridanek force-pushed the jd_wip_image_building_lvm_overlay_etc branch 2 times, most recently from 4dda228 to 76ee832 Compare June 21, 2024 07:55
@jiridanek jiridanek requested a review from atheo89 June 21, 2024 08:12
@jiridanek
Copy link
Member Author

/label tide/merge-method-squash

@jiridanek
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests d581cfd link true /test notebooks-e2e-tests
ci/prow/intel-notebooks-e2e-tests d581cfd link true /test intel-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek
Copy link
Member Author

/test runtimes-ubi8-e2e-tests

@jiridanek
Copy link
Member Author

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This PR creates a LVM overlay,
increasing the available disk space from previous 66GB to 82GB by default,
and 106GB when building any amd/cude/pytorch/tensorflow image.
@jiridanek jiridanek force-pushed the jd_wip_image_building_lvm_overlay_etc branch from d581cfd to ba9095d Compare June 26, 2024 10:53
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jiri for this enchantment!

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 088ab3c into opendatahub-io:main Jun 26, 2024
32 checks passed
jstourac pushed a commit to jstourac/notebooks that referenced this pull request Jul 19, 2024
…ndatahub-io#577)

* ci: increase available disk space for GHA container image builds

This PR creates a LVM overlay,
increasing the available disk space from previous 66GB to 82GB by default,
and 106GB when building any amd/cude/pytorch/tensorflow image.

* fixup from review, add intel

(cherry picked from commit 088ab3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants